feat: add ability to override nginx domain #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Dec 17, 2024
joelmccoy
force-pushed
the
add-nginx-value-override
branch
from
6b9a762 to
27e8c9e
Compare
mjnagel
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the ability to override the nginx domain. This is helpful for scenarios in which you want to setup uds-k3d with a domain other than uds.dev. It will be useful for setting up demo/dev environments that don't use uds.dev. Useful for the runtime folks as they are doing something nasty to get this working.
Related Issue
Fixes #
Relates to #
Type of change
Checklist before merging